fix: potentially crashing typecast in LoadRecentFilter

ansgarbecker · ansgarbecker · commit da075910453c · 2026-02-18T14:05:17.000+01:00
Refs #2411
diff --git a/source/main.pas b/source/main.pas
@@ -12047,8 +12047,13 @@ procedure TMainForm.LoadRecentFilter(Sender: TObject);
   // Event handler for both dynamic popup menu items and filter combobox
   if Sender is TMenuItem then
     key := (Sender as TMenuItem).Tag
-  else
-    key := (Sender as TComboBox).ItemIndex+1;
+  else if Sender is TComboBox then
+    key := (Sender as TComboBox).ItemIndex+1
+  else begin
+    Beep;
+    LogSQL('Unhandled '+Sender.ClassName+' in LoadRecentFilter');
+    Exit;
+  end;
   Path := AppSettings.AppendDelimiter(GetRegKeyTable) + REGKEY_RECENTFILTERS;
   if AppSettings.SessionPathExists(Path) then begin
     AppSettings.SessionPath := Path;
