feat: add toolbar button for toggling reverse foreign key listing, so the user has the chance to disable its potentially long during query

ansgarbecker · ansgarbecker · commit 938f303bda7b · 2026-02-28T15:23:56.000+01:00
Refs #1825
diff --git a/extra/locale/heidisql.po b/extra/locale/heidisql.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: HeidiSQL\n"
 "POT-Creation-Date: 2012-11-05 21:40\n"
-"PO-Revision-Date: 2026-02-28 11:20+0100\n"
+"PO-Revision-Date: 2026-02-28 15:20+0100\n"
 "Last-Translator: Ansgar Becker <anse@heidisql.com>\n"
 "Language-Team: English (http://www.transifex.com/projects/p/heidisql/language/en/)\n"
 "Language: en\n"
@@ -6794,3 +6794,9 @@ msgstr "Wine support is deprecated. Future versions will not work reliably. Use
 
 msgid "deprecated"
 msgstr "deprecated"
+
+msgid "Reverse"
+msgstr "Reverse"
+
+msgid "Show reverse foreign keys"
+msgstr "Show reverse foreign keys"
diff --git a/source/apphelpers.pas b/source/apphelpers.pas
@@ -233,7 +233,7 @@   TWinControlHelper = class helper for TWinControl
     asThemePreviewWidth, asThemePreviewHeight, asThemePreviewTop, asThemePreviewLeft,
     asCreateDbCollation, asRealTrailingZeros,
     asSequalSuggestWindowWidth, asSequalSuggestWindowHeight, asSequalSuggestPrompt, asSequalSuggestRecentPrompts,
-    asReformatter, asReformatterNoDialog, asAlwaysGenerateFilter,
+    asReformatter, asReformatterNoDialog, asAlwaysGenerateFilter, asDisplayReverseForeignKeys,
     asGenerateDataNumRows, asGenerateDataNullAmount, asWebOnceAction, asDisplayLogPanel, asDisplayTreeFilters,
     asUnused);
   TAppSetting = record
@@ -3783,6 +3783,7 @@ constructor TAppSettings.Create;
   InitSetting(asReformatter,                      'Reformatter',                           0);
   InitSetting(asReformatterNoDialog,              'ReformatterNoDialog',                   0);
   InitSetting(asAlwaysGenerateFilter,             'AlwaysGenerateFilter',                  0, False);
+  InitSetting(asDisplayReverseForeignKeys,        'DisplayReverseForeignKeys',             0, False);
   InitSetting(asGenerateDataNumRows,              'GenerateDataNumRows',                   1000);
   InitSetting(asGenerateDataNullAmount,           'GenerateDataNullAmount',                10);
 
diff --git a/source/table_editor.lfm b/source/table_editor.lfm
@@ -498,6 +498,15 @@ object frmTableEditor: TfrmTableEditor
           ImageIndex = 26
           OnClick = btnClearForeignKeysClick
         end
+        object btnShowReverseForeignKeys: TToolButton
+          Left = 1
+          Hint = 'Show reverse foreign keys'
+          Top = 86
+          Caption = 'Reverse'
+          ImageIndex = 40
+          Style = tbsCheck
+          OnClick = btnShowReverseForeignKeysClick
+        end
       end
       object listForeignKeys: TLazVirtualStringTree
         AnchorSideLeft.Control = tlbForeignKeys
@@ -581,23 +590,25 @@ object frmTableEditor: TfrmTableEditor
         Top = 0
         Width = 178
         Anchors = [akTop, akLeft, akRight, akBottom]
+        AutoWidthLastColumn = True
         Columns = <        
           item
             AutoSize = True
             Caption = 'Database'
             Width = 63
           end        
           item
-            AutoSize = True
             Caption = 'Table'
-            Width = 44
+            Width = 111
           end>
         ColumnClick = False
         ReadOnly = True
         RowSelect = True
         SmallImages = MainForm.ImageListMain
         TabOrder = 2
+        Visible = False
         ViewStyle = vsReport
+        OnDblClick = ListViewReverseForeignKeysDblClick
       end
       object spltForeignKeyListings: TSplitter
         AnchorSideTop.Control = tabForeignKeys
@@ -611,6 +622,7 @@ object frmTableEditor: TfrmTableEditor
         Align = alNone
         Anchors = [akTop, akBottom]
         ResizeAnchor = akRight
+        Visible = False
       end
     end
     object tabCheckConstraints: TTabSheet
diff --git a/source/table_editor.pas b/source/table_editor.pas
@@ -48,6 +48,7 @@   TfrmTableEditor = class(TFrame)
     comboCollation: TComboBox;
     lblEngine: TLabel;
     comboEngine: TComboBox;
+    btnShowReverseForeignKeys: TToolButton;
     treeIndexes: TLazVirtualStringTree;
     tlbIndexes: TToolBar;
     btnAddIndex: TToolButton;
@@ -101,6 +102,8 @@   TfrmTableEditor = class(TFrame)
     btnClearCheckConstraints: TToolButton;
     listCheckConstraints: TLazVirtualStringTree;
     Copy1: TMenuItem;
+    procedure btnShowReverseForeignKeysClick(Sender: TObject);
+    procedure ListViewReverseForeignKeysDblClick(Sender: TObject);
     procedure Modification(Sender: TObject);
     procedure btnAddColumnClick(Sender: TObject);
     procedure btnRemoveColumnClick(Sender: TObject);
@@ -294,6 +297,7 @@ constructor TfrmTableEditor.Create(AOwner: TComponent);
   for i in ColNumsCheckboxes do begin
     listColumns.Header.Columns[i].Alignment := taCenter;
   end;
+  btnShowReverseForeignKeys.Down := AppSettings.ReadBool(asDisplayReverseForeignKeys);
   FixVT(listColumns);
   FixVT(treeIndexes);
   FixVT(listForeignKeys);
@@ -453,6 +457,7 @@ procedure TfrmTableEditor.Init(Obj: TDBObject);
   CreateCodeValid := False;
   AlterCodeValid := False;
   FReverseForeignKeysLoaded := False;
+  btnShowReverseForeignKeysClick(Self);
   PageControlMainChange(Self); // Foreign key editor needs a hit
   // Buttons are randomly moved, since VirtualTree update, see #440
   btnSave.Top := Height - btnSave.Height - 3;
@@ -1051,6 +1056,42 @@ procedure TfrmTableEditor.Modification(Sender: TObject);
   end;
 end;
 
+procedure TfrmTableEditor.ListViewReverseForeignKeysDblClick(Sender: TObject);
+var
+  ClickItem: TListItem;
+  Obj: TDBObject;
+begin
+  // Create virtual object and let mainform search for it in the tree
+  ClickItem := ListViewReverseForeignKeys.Selected;
+  if not Assigned(ClickItem) then
+    Exit;
+  Obj := TDBObject.Create(DBObject.Connection);
+  Obj.NodeType := lntTable;
+  Obj.Database := ClickItem.Caption;
+  Obj.Name := ClickItem.SubItems[0];
+  MainForm.ActiveDbObj := Obj;
+end;
+
+procedure TfrmTableEditor.btnShowReverseForeignKeysClick(Sender: TObject);
+var
+  DoShow: Boolean;
+begin
+  DoShow := btnShowReverseForeignKeys.Down;
+  if DoShow then begin
+    spltForeignKeyListings.Visible := True;
+    ListViewReverseForeignKeys.Visible := True;
+    spltForeignKeyListings.BringToFront;
+    ListViewReverseForeignKeys.BringToFront;
+    LoadReverseForeignKeys(Sender);
+  end
+  else begin
+    ListViewReverseForeignKeys.Visible := False;
+    spltForeignKeyListings.Visible := False;
+    listForeignKeys.Width := listForeignKeys.Parent.Width - tlbForeignKeys.Width;
+  end;
+  AppSettings.WriteBool(asDisplayReverseForeignKeys, DoShow);
+end;
+
 
 procedure TfrmTableEditor.btnAddColumnClick(Sender: TObject);
 var
@@ -3086,9 +3127,15 @@ procedure TfrmTableEditor.LoadReverseForeignKeys(Sender: TObject);
 begin
   if FReverseForeignKeysLoaded then
     Exit;
+  if not ListViewReverseForeignKeys.Visible then
+    Exit;
+  if not ObjectExists then // Jump out early when creating a new table
+    Exit;
   SqlGet := DBObject.Connection.SqlProvider.GetSql(qGetReverseForeignKeys, DBObject.AsStringMap);
-  if SqlGet.IsEmpty then
+  if SqlGet.IsEmpty then begin
+    MainForm.LogSQL(_('Database does not provide reverse foreign key listing'));
     Exit;
+  end;
   ListViewReverseForeignKeys.BeginUpdate;
   ListViewReverseForeignKeys.Clear;
   try
