feat: use the more native MessageDlg on all platforms when we don't need additional dialog features

ansgarbecker · ansgarbecker · commit 8c0e61f372bf · 2025-12-23T14:18:39.000+01:00
diff --git a/source/apphelpers.pas b/source/apphelpers.pas
@@ -438,7 +438,7 @@   TAppSettings = class(TObject)
   AppLanguageMoBasePath: String;
   MutexHandle: THandle = 0;
   SystemImageList: TImageList = nil;
-  mtCriticalConfirmation: TMsgDlgType = mtCustom;
+  mtCriticalConfirmation: TMsgDlgType = mtWarning;
   //ConfirmIcon: TIcon;
   NumberChars: TSysCharSet;
   LibHandleUser32: THandle;
@@ -2323,6 +2323,13 @@ function MessageDialog(const Title, Msg: string; DlgType: TMsgDlgType; Buttons:
       Btn.Default := True;
   end;
 begin
+
+  if (KeepAskingSetting = asUnused) and (FooterText.IsEmpty) then begin
+    // Show the more native MessageDlg when we don't need additional dialog features
+    Result := MessageDlg(Title, Msg, DlgType, Buttons, 0);
+    Exit;
+  end;
+
   // Remember current path and restore it later, so the caller does not try to read from the wrong path after this dialog
   AppSettings.StorePath;
 
