fix: detected empty text DEFAULT value for table columns

ansgarbecker · ansgarbecker · commit 4c0617d0a83e · 2025-12-05T10:19:14.000+01:00
I suspect IfThen() to be the cause, telling FPC it may execute ExtractLiteral() more than one time.
diff --git a/source/dbconnection.pas b/source/dbconnection.pas
@@ -5261,7 +5261,7 @@ function TDBConnection.ExtractLiteral(var SQL: String; Prefix: String): String;
       else if not InLiteral then
         break;
     end;
-    Result := Copy(SQL, LitStart, i-LitStart-1);
+    Result := Copy(SQL, LitStart, i-LitStart);
     Result := UnescapeString(Result);
     Delete(SQL, 1, i);
   end;
@@ -5862,7 +5862,10 @@ function TDBConnection.GetTableColumns(Table: TDBObject): TTableColumnList;
     end
     else if IsTextDefault(DefText, Col.DataType) then begin
       Col.DefaultType := cdtText;
-      Col.DefaultText := IfThen(DefText.StartsWith(''''), ExtractLiteral(DefText, ''), DefText);
+      if DefText.StartsWith('''') then
+        Col.DefaultText := ExtractLiteral(DefText, '')
+      else
+        Col.DefaultText := DefText;
     end
     else begin
       Col.DefaultType := cdtExpression;
