fix: missing selection highlighting and auto-uppercasing in data tab filter editor

ansgarbecker · ansgarbecker · commit 2e31c5e0eca4 · 2026-01-14T16:43:48.000+01:00
diff --git a/source/main.lfm b/source/main.lfm
@@ -2825,6 +2825,7 @@ object MainForm: TMainForm
               MouseLinkColor.Foreground = clBlue
               LineHighlightColor.Background = clNone
               LineHighlightColor.Foreground = clNone
+              OnProcessCommand = SynMemoQueryProcessCommand
               OnStatusChange = SynMemoFilterStatusChange
               inline SynLeftGutterPartList1: TSynGutterPartList
               end
diff --git a/source/main.pas b/source/main.pas
@@ -7132,14 +7132,14 @@ procedure TMainForm.SynMemoQueryProcessCommand(Sender: TObject;
       TableIndex := SynSQLSynUsed.TableNames.IndexOf(Token);
       if TableIndex > -1 then
         Replacement := SynSQLSynUsed.TableNames[TableIndex];
-      Editor.BlockBegin := StartPt;
-      Editor.BlockEnd := EndPt;
-      Editor.SelText := Replacement;
-
-      Editor.CaretXY := Point(ColIdx, LineIdx);
-
-      Editor.SelText := AChar;
-      AChar := '';  // consume char so it is not inserted again
+      if Token <> Replacement then begin
+        Editor.BlockBegin := StartPt;
+        Editor.BlockEnd := EndPt;
+        Editor.SelText := Replacement;
+        Editor.CaretXY := Point(ColIdx, LineIdx);
+        Editor.SelText := AChar;
+        AChar := '';  // consume char so it is not inserted again
+      end;
     end;
   end;
 end;
@@ -10183,6 +10183,9 @@ procedure TMainForm.SynMemoFilterStatusChange(Sender: TObject; Changes: TSynStat
   PanelHeight := Max(PanelHeight, btnFilterApply.Top + btnFilterApply.Height + 5);
   if PanelHeight <> pnlFilter.Height then
     pnlFilter.Height := PanelHeight;
+
+  // Required for selection highlighting
+  GlobalSynEditStatusChange(Sender, Changes);
 end;
 
 
