fix: several crash causes Host subtabs when connection is lost externally

ansgarbecker · ansgarbecker · commit 1029657e9cda · 2026-02-23T13:40:13.000+01:00
This also changes the dodgy default text "Node" in any VirtualTree's cell to "-" Refs #1875
diff --git a/source/apphelpers.pas b/source/apphelpers.pas
@@ -1491,6 +1491,7 @@ procedure FixVT(VT: TVirtualStringTree; IsResultGrid: Boolean=False);
     end;
     VT.EndUpdate;
   end;
+  VT.DefaultText := '-'; // "Node" by default
   {$IFNDEF WINDOWS}
   // Disable grid lines, looks ok on Windows with dotted light lines, but not on macOS and Linux
   if (toHotTrack in VT.TreeOptions.PaintOptions) then
diff --git a/source/main.pas b/source/main.pas
@@ -9208,6 +9208,8 @@ procedure TMainForm.HostListGetImageIndex(Sender: TBaseVirtualTree; Node: PVirtu
   if Sender = ListProcesses then begin
     Idx := Sender.GetNodeData(Node);
     Results := GridResult(Sender);
+    if not Results.Connection.Active then
+      Exit;
     Results.RecNo := Idx^;
     case Kind of
       ikNormal, ikSelected: begin
@@ -9252,11 +9254,15 @@ procedure TMainForm.HostListGetText(Sender: TBaseVirtualTree; Node: PVirtualNode
 begin
   Idx := Sender.GetNodeData(Node);
   Results := GridResult(Sender);
-  // See issue #3416
-  if (Results = nil) and (Sender <> ListVariables) then
-    Exit;
-  if Results <> nil then
+
+  // See issue #3416. Note: ListVariables does not depend on a live result, but on a StringList.
+  if Sender <> ListVariables then begin
+    // See issue #1875
+    if (Results = nil) or (not Results.Connection.Active) then
+      Exit;
     Results.RecNo := Idx^;
+  end;
+
 
   if (Sender = ListStatus) and (Column in [1,2,3]) then begin
     CellText := Results.Col(1);
