Skip to content

check if transfer recipient already wears hat#75

Merged
spengrah merged 1 commit intodevelopfrom
fix/transfer-balance-check
Dec 8, 2022
Merged

check if transfer recipient already wears hat#75
spengrah merged 1 commit intodevelopfrom
fix/transfer-balance-check

Conversation

@spengrah
Copy link
Copy Markdown
Member

@spengrah spengrah commented Dec 8, 2022

Adds a check to ensure that transferHat does not result in an account having a balance of more than 1 of any given hat

@spengrah spengrah requested a review from nintynick December 8, 2022 16:19
@spengrah spengrah marked this pull request as ready for review December 8, 2022 16:30
Copy link
Copy Markdown
Member

@nintynick nintynick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find! this doesn't take us over the gas limit for Hats.sol, right? if not, lgtm

@spengrah
Copy link
Copy Markdown
Member Author

spengrah commented Dec 8, 2022

good find! this doesn't take us over the gas limit for Hats.sol, right? if not, lgtm

Nope, we're still under the max contract size

@spengrah spengrah merged commit fae3e36 into develop Dec 8, 2022
@spengrah spengrah deleted the fix/transfer-balance-check branch December 8, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants