2 - cap size of details and imageURI#114
Conversation
nintynick
left a comment
There was a problem hiding this comment.
looks good, though I would prefer if imageURI was even further restricted (say 1000 bytes). and it may be helpful to explain in the comment a bit how we got to 7000.
|
This PR appears to cap the length in the |
|
Same thing with the |
@zobront the thinking here is that we don't need the check on creation since — due to writing being more expensive than reading — it will be impossible to write a single string that can DOS reads. Only by incrementally updating can a DOS be achieved, hence the choice to apply at the Let me know if you disagree with this analysis.
Ah, good catch. Since this can be called from within |
sherlock-audit/2023-02-hats-judging#2