Remove usage of penv library#137
Merged
viniciussanchez merged 1 commit intoHashLoad:masterfrom Apr 24, 2023
Merged
Conversation
Remove use of penv library (github.com/snakeice/penv) due to a bug when executed with an Azure Devops agent
Contributor
Author
|
Fixes #136 |
Contributor
Author
|
@snakeice The bug only occurs when executed by an Azure Devops agent. I don't know exactly how it works, but my guess is that the current user has no PATH env variable, or something like that. |
Member
|
Penv is used to set persistent environment, os.Setenv is runtime only. We use persistent mode to have binary tools installed by the boss and global stuff mapped. I don't know the behavior removing this in general, maybe changing to warning the error already solves it. |
Contributor
Author
|
To clarify:
With the modifications I suggested, it works. But I did not test 100%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of the environment variables under Windows in the case of the program being executed with an Azure Devops agent. The penv library (github.com/snakeice/penv) seems to not work in that scenario.
Typo on variable name (splitedPath)