Fix boot crash when v8 saves are present#6157
Merged
serprex merged 1 commit intoHarbourMasters:developfrom Jan 18, 2026
Merged
Conversation
943f2c3 to
82a5d23
Compare
serprex
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a crash in
StartupCheckAndInitMetawhen processing save files that lacked afilenameLanguageproperty (i.e. saves from before v9). The crash was happening when booting Ship.Prior to #5817, these files were able to load fine, as
SaveManager::LoadDatawas defaulting to0for this property. So, to mimic that behavior, I’ve changed the new code to also default to0.(For some reason, one of my save files was from v8.0.6. But this fix may help others with a lingering old save.)
Build Artifacts