Disable Fixed Camera Enhancement#6083
Merged
serprex merged 6 commits intoHarbourMasters:developfrom Jan 3, 2026
Merged
Conversation
* Refactor DisableFixedCamera for memory safety - Add IsFixedCameraType() helper to reduce code duplication - Inline trivial wrapper functions (StoreCamType/RestoreCamType) - Early-exit when enhancement is disabled before computing player state - Cache CVAR value to avoid repeated CVarGetInteger calls - Fix memory leak by cleaning up allocated backups on scene change - Simplify player null checks (player && vs player != nullptr) - Reorganize control flow for better readability * c lang
serprex
reviewed
Jan 3, 2026
serprex
reviewed
Jan 3, 2026
serprex
reviewed
Jan 3, 2026
also fixed guard for opening cutscene
Contributor
Author
|
implemented suggestions, and fixed links house guard to be specific to just the opening cutscene |
serprex
reviewed
Jan 3, 2026
serprex
reviewed
Jan 3, 2026
serprex
reviewed
Jan 3, 2026
serprex
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an enhancement to disable the fixed cam used by prerendered background scenes. Intended for mods that replace these scenes with fully modeled areas. It requires
Disable 2D Pre-Rendered Scenesto be enabled first. I did not include shops as the lack of a doors at the entrance makes them look really wonky when exiting, link just falls through the ground on his way out. It includes the Market, ToT Exterior, Back Alley, all houses, Granny's Potion Shop (because it actually has a door), and the Shooting Gallery Building.Only minor issue I've spotted is disabling the enhancement while in a scene this enhancement effects, makes the ocarina cam not zoom into the player like it should, this fixes itself after a scene change.
Big thanks to @PurpleHato for giving my code a good look through and doing some needed cleanups! And thank you to @OtherBlue for giving me the tip about VBs.
Some screenshots using Djipi's 3DS Experience:
Build Artifacts