Modularize enemy defeat count hook & fix counting bugs#5885
Conversation
|
I found several increment errors while testing: Skullwalltula and Big Skulltula is incrementing Skull Kid instead and skull kid increments skullwalltula. |
|
Are these errors present on |
|
It seems to be bugged in completly different ways: |
|
I'm testing on develop and I haven't gone through everything yet, but so far all the issues you have mentioned are showing up there, too. |
|
I'm gonna guess that most of these are simply misalignments between counters and labels. I can already confirm that to be true for the following:
|
|
Are the enemy names meant to be kept in alphabetical order? I'm hesitant to change the order of the enum values because that'll mess up everyone's enemy defeat counts as opposed to just switching the labels. |
d3d816f to
ddbf75f
Compare
|
@JordanLongstaff cleaning up the code to be based less on implicit indexing would be good, but LGTM |
Not just copy-pasted as one big hook; it's been broken up into multiple hooks by actor ID.
Build Artifacts