Add some NTSC Player Name decoding in Save Editor#5867
Add some NTSC Player Name decoding in Save Editor#5867serprex merged 4 commits intoHarbourMasters:developfrom
Conversation
61aa37f to
a7d4ab0
Compare
|
The second commit adds Japanese-character decoding. This involves adding a Japanese font to the GUI (currently Noto Sans JP) so please regenerate "soh.o2r" (e.g. cmake --build build-cmake --target GenerateSohOtr) when building and testing from source, otherwise the app will crash on launch due to the missing font. |
a7d4ab0 to
f0f45d5
Compare
|
does this only work with NTSC extraction? Seeing toggle in dev tools, but not seeming to impact naming menu |
The NTSC name encoding (contains Japanese and English characters) works only if you have a NTSC rom. The type of filename keyboard shows up on new game is decided based on what versions of ROM you have and what game language you selected in SoH's settings menu. The name encoding toggle in Save Editor works only if you're in middle of gameplay. |
f0f45d5 to
cc7473a
Compare
This PR adds an ability to correctly display Player Name in Save Editor when using NTSC charset, as long as the Player Name only uses alphabets, numbers, whitespace, '.', and '-'. Japanese characters are currently shown as '?'.
Build Artifacts