Skip to content

refactor ganon's castle#5664

Merged
Malkierian merged 1 commit intoHarbourMasters:developfrom
serprex:refactor-ganon
Dec 15, 2025
Merged

refactor ganon's castle#5664
Malkierian merged 1 commit intoHarbourMasters:developfrom
serprex:refactor-ganon

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Jul 10, 2025

@serprex serprex marked this pull request as ready for review July 11, 2025 04:11
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverse shadow trial logic is a pain, but you handled it well for the most part, just remember to double check rang ranges as it can be hard to eyeball.

@serprex serprex force-pushed the refactor-ganon branch 3 times, most recently from b9e4fd9 to f72228e Compare July 12, 2025 05:48
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the settings tooltip change and I'll approve

@serprex serprex force-pushed the refactor-ganon branch 2 times, most recently from b7924ae to c89a5c7 Compare July 12, 2025 12:24
@serprex serprex mentioned this pull request Jul 13, 2025
@Pepe20129 Pepe20129 requested a review from Pepper0ni August 1, 2025 17:57
Copy link
Contributor

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "orb room" would be a more descriptive name for the final rooms but it doesn't really matter

@serprex serprex force-pushed the refactor-ganon branch 3 times, most recently from fcf21ca to 33931bc Compare September 30, 2025 20:13
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few doorsanity oversights and some other bomb jumps and issues

@serprex serprex force-pushed the refactor-ganon branch 2 times, most recently from f92e065 to 3f2c5d4 Compare October 17, 2025 13:05
Copy link
Contributor

@Pepper0ni Pepper0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 last change and this looks done

@Malkierian Malkierian merged commit 971c3c5 into HarbourMasters:develop Dec 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants