refactor ganon's castle#5664
Merged
Malkierian merged 1 commit intoHarbourMasters:developfrom Dec 15, 2025
Merged
Conversation
Pepper0ni
suggested changes
Jul 11, 2025
Contributor
Pepper0ni
left a comment
There was a problem hiding this comment.
reverse shadow trial logic is a pain, but you handled it well for the most part, just remember to double check rang ranges as it can be hard to eyeball.
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
b9e4fd9 to
f72228e
Compare
Pepper0ni
suggested changes
Jul 12, 2025
Contributor
Pepper0ni
left a comment
There was a problem hiding this comment.
Just the settings tooltip change and I'll approve
b7924ae to
c89a5c7
Compare
Draft
Pepe20129
approved these changes
Aug 1, 2025
Contributor
Pepe20129
left a comment
There was a problem hiding this comment.
I think "orb room" would be a more descriptive name for the final rooms but it doesn't really matter
Pepper0ni
approved these changes
Aug 10, 2025
411b619 to
1a0d12d
Compare
fcf21ca to
33931bc
Compare
33931bc to
a505d76
Compare
Pepper0ni
suggested changes
Oct 16, 2025
Contributor
Pepper0ni
left a comment
There was a problem hiding this comment.
A few doorsanity oversights and some other bomb jumps and issues
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Show resolved
Hide resolved
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Show resolved
Hide resolved
f92e065 to
3f2c5d4
Compare
Pepper0ni
approved these changes
Oct 25, 2025
Contributor
Pepper0ni
left a comment
There was a problem hiding this comment.
1 last change and this looks done
soh/soh/Enhancements/randomizer/location_access/dungeons/ganons_castle.cpp
Outdated
Show resolved
Hide resolved
Pepe20129
approved these changes
Nov 1, 2025
e3832fb to
8de618d
Compare
8de618d to
a506ea1
Compare
a506ea1 to
07ac1f3
Compare
Malkierian
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Artifacts