Fix Jabu Water Switch GS Logic#5580
Closed
Malkierian wants to merge 2 commits intoHarbourMasters:develop-blairfrom
Closed
Fix Jabu Water Switch GS Logic#5580Malkierian wants to merge 2 commits intoHarbourMasters:develop-blairfrom
Malkierian wants to merge 2 commits intoHarbourMasters:develop-blairfrom
Conversation
Contributor
Author
|
Definitely need a sanity check on the logic being done here, lots of parentheses being thrown around. |
Contributor
|
The issue in the provided seed was actually on the entrance access to the ledge, as shown in #5581, so this PR isn't needed and just makes assumptions about how the ledge was accessed. The logic text feature may be doing more harm than good at this point. |
Contributor
Author
|
Had nothing to do with the logic text feature, I just didn't realize that the GS was in the region where you were already on the ledge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Killing with bombs used to be on its own as being valid access for it, even as child with swim shuffled, but there's no way to climb that wall without the water as child. This fixes that, as well as expands the logic checks to allow for more flexibility with glitches later.
Also threw in a forward declaration cleanup.
Build Artifacts