Skip to content

Headphones setting in game should now work.#557

Merged
Kenix3 merged 1 commit intoHarbourMasters:developfrom
Kenix3:fixes_headphones_setting
Jun 28, 2022
Merged

Headphones setting in game should now work.#557
Kenix3 merged 1 commit intoHarbourMasters:developfrom
Kenix3:fixes_headphones_setting

Conversation

@Kenix3
Copy link
Collaborator

@Kenix3 Kenix3 commented Jun 27, 2022

Resolves #13

@briaguya0
Copy link
Contributor

#define aAddMixer(pkt, s, d, c) aAddMixerImpl(s, d, c)

uses s, d, c which i'm assuming stands for source, destination, count

could be nice to update those to match

@Kenix3
Copy link
Collaborator Author

Kenix3 commented Jun 27, 2022

#define aAddMixer(pkt, s, d, c) aAddMixerImpl(s, d, c)

uses s, d, c which i'm assuming stands for source, destination, count

could be nice to update those to match

Most of the macros are wrong in a similar manner, but yes, they can be updated.

Copy link
Contributor

@briaguya0 briaguya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that i know aAddMixer is far from the only macro with out of order args in mixer.h/mixer.c, i agree fixing all those in a different PR is the move

:shipit:

@Kenix3 Kenix3 merged commit cc22fe1 into HarbourMasters:develop Jun 28, 2022
@dcvz dcvz added this to the Rachael Alfa (3.0.0) milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headphone setting is completely broken.

5 participants