Better account for punctuation in auto-format#5424
Closed
Pepper0ni wants to merge 3 commits intoHarbourMasters:develop-blairfrom
Closed
Better account for punctuation in auto-format#5424Pepper0ni wants to merge 3 commits intoHarbourMasters:develop-blairfrom
Pepper0ni wants to merge 3 commits intoHarbourMasters:develop-blairfrom
Conversation
Contributor
Author
|
obsoleted by #5426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR edits auto-format to see all punctuation as valid targets for breaks even if there is a space on the line. This also adds a fallback to more gracefully handle any excessively long words, and fixes a small type in one of the HBA hints.
A Translation of the HBA hint without epona is supplied to test the new system, as the current version crashed when processing "#Pferdebogenschießen#-Herausforderung!"
A few test runs on this (or ideally #5422 with this added) are recommended before merging to check for any regressions in auto-format.
Build Artifacts