Fix some options not updating correctly when dropping jsons and applying Presets#5240
Merged
Archez merged 4 commits intoHarbourMasters:developfrom Mar 29, 2025
Merged
Conversation
Archez
reviewed
Mar 28, 2025
Archez
approved these changes
Mar 28, 2025
aMannus
reviewed
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-Runs ShipInit funcs when dropping a ship json or applying a preset, causing in-game behavior of options to properly update. Also adds some static bools to ensure the ShipInit funcs that register randomizer item locations only run once. It wasn't necessarily a problem that they would've been running twice, but it was unnecessary.
Build Artifacts