Skip to content

Update Dev Tools Windows#5220

Merged
aMannus merged 2 commits intoHarbourMasters:developfrom
aMannus:mono-font-stats-window
Mar 26, 2025
Merged

Update Dev Tools Windows#5220
aMannus merged 2 commits intoHarbourMasters:developfrom
aMannus:mono-font-stats-window

Conversation

@aMannus
Copy link
Contributor

@aMannus aMannus commented Mar 26, 2025

Fixes #5217

Updates the naming of the newer overrides for LUS windows to get them in line with other windows. Also updated the console font to MonoLarger instead of MonoSmall because it was uhh.. small.

Also basically copied the Stats menu from LUS into SoH to add the Mono font to that too. I couldn't do the same as the other menu's because the Stats window in LUS has its functions in private, not protected.

Build Artifacts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this window is not many lines of code, but unless we have a reason to render separate content, I think we should just extend the LUS one like the other two windows. I'd rather not have to worry about backporting changes even if that might be rare.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really didn't feel like going through LUS and changing the functions from private to protected there. I'm also still really not on board with LUS providing windows in general. IMO it's lead to more problems and complications than it has actually been convenient.

If this is a hard requirement for you I guess I'll do it, but I think we need to have a discussion about LUS providing ImGui windows at some point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.. they're private unlike the other windows.. shame. I'll let it pass then.

@aMannus aMannus merged commit 057434c into HarbourMasters:develop Mar 26, 2025
5 checks passed
@aMannus aMannus deleted the mono-font-stats-window branch March 30, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[devleop and release] FPS tracker in dev tools > Stats is jittery when frame rate is unstable

2 participants