Fix Tektite texture body break parts for custom skeletons#5214
Merged
aMannus merged 2 commits intoHarbourMasters:developfrom Mar 26, 2025
Merged
Fix Tektite texture body break parts for custom skeletons#5214aMannus merged 2 commits intoHarbourMasters:developfrom
aMannus merged 2 commits intoHarbourMasters:developfrom
Conversation
aMannus
reviewed
Mar 26, 2025
aMannus
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Tektites, the body breakpart system looks for a specific tektite DL by name to decide if the blue or red body textures should be loaded into segment positions. We've already changed this in the past to do a string comparison because of how our resources work, but this check fails whenever a custom skeleton is used for Tektites that does not use the exact same DL names.
To help with mod support, I've added a fallback to just check that the parent actor has the Tektite ID. Also add region comments to clarify the port change.
I believe this should be safe as even I don't think any other breakpart should trigger this (considering the param and parent relationship), and even if it did, all that would happen is the segment values would be unused.
Build Artifacts