Merged
Conversation
Temporarily rename new menu's UIWidgets to UIWidgets2 to allow both menu systems to coexist temporarily.
Rename 2ship UIWidgets to UIWidgets2 to complete facilitation of both menus working for now.
Fix search function not looking past first columns.
Modern menu
Add ability to not embed popout windows when not popped out. Add ability to hide the button for WindowButtons. Fix Entrance Tracker from showing when not enabled.
Fix entrance tracker settings window original size declaration.
Fix sidebar sections starting in second column.
Fix color picker end spacing. Convert everything in check tracker settings to UIWidgets2 (except color pickers and section headers). Make all tracker windows not embed.
…round color. Fix tracker and network prefixes.
Audio editor + gameplay stats done
Improve Randomizer Menu and convert Plandomizer Menu
…ixes Fix slider width calculation and allow combobox LabelPosition::None
Convert Collision Viewer.
Convert Actor Viewer.
Theme Value Viewer.
Removed UIWidgets references from Controller Config, and restored SoH version.
Rename UIWidgets2 to UIWidgets. Move Accessibility and Language options to new menu.
Remove menubar registration.
…n-menu. Update new menu preset functionality.
This was referenced Mar 15, 2025
This was
linked to
issues
Mar 15, 2025
serprex
reviewed
Mar 15, 2025
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, it's finally here! This updates everything's theming, in addition to moving it all from the menubar to the new menu, except for main portions of the controller configuration, and the console and gfx debugger windows (those being from LUS). Stats also isn't updated, but doesn't have any widgets to theme.
Note that not everything is converted to the new menu UIWidgets for now, but everything is themed properly. The one point of feedback I'd like for this the advanced resolution settings, as for whether I need to make them into a window again rather than being integrated into the menu.
Also keep in mind, not everything is fully updated for organization or removal (for enhancements that we want to axe). This focused only on getting all the settings and functionality into the new menu.
Oh, yeah, this also removes the menubar registration, so it doesn't show up at all.
Special thanks to @aMannus and @leggettc18 for helping to move everything over.
Build Artifacts