Skip to content

Fix more missing location pool exclusions#5108

Merged
Malkierian merged 4 commits intoHarbourMasters:developfrom
leggettc18:fix/randomizer/more_loc_pool_exclusions
Mar 12, 2025
Merged

Fix more missing location pool exclusions#5108
Malkierian merged 4 commits intoHarbourMasters:developfrom
leggettc18:fix/randomizer/more_loc_pool_exclusions

Conversation

@leggettc18
Copy link
Contributor

@leggettc18 leggettc18 commented Mar 7, 2025

Also threw in a sanity assert that the Item Pool isn't larger than the Location Pool during generation (the Item Pool being smaller or equal is fine, the code already handles that just fine by placing Junk if the item pool runs out).

Build Artifacts

This will catch any issues where too many items are getting
added to the pool in Debug mode. It only checks to make sure the item
pool is smaller than the location pool, as the code actually handles
that just fine by placing Junk if the pool runs out. The Item Pool being
larger than the location pool though could easily result in items not
being placed. Logic should prevent a seed like that actually being
generated, but No Logic does no such checks.
@Malkierian Malkierian merged commit c54883d into HarbourMasters:develop Mar 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants