Upgrades Custom Messages to Hooks and ShipInit#5101
Upgrades Custom Messages to Hooks and ShipInit#5101serprex merged 121 commits intoHarbourMasters:developfrom
Conversation
25e3154 to
9118744
Compare
cf12650 to
4093eda
Compare
Only for the items, other things previously covered by CustomMessage_Retrieve if exists have not yet been covered as of this commit and will either load their vanilla text or crash.
Specifically Dampe, Greg, Warp Songs, Frogs, Loach, Fishing Pole, and Saria
This is the last of the static hints
|
I removed Do Not Merge now that this is up to date with latest dev and I did a playthrough of it and couldn't find anything broken. Hinted shop items are a little weird since they show up as something like "They say a child shopkeeper sells Buy Hylian Shield", but that's the only blemish I've found and I don't really know of much of a way around it, other than maybe renaming them to something like "Hylian Shield (Buy)" or something like that so it still grammatically works and is still clear it's referring to the shop item. |
|
@PurpleHato may have thoughts here re shop hints, why can't string interpolation remove |
|
Hmm, would need to check the other languages to see if it would be that simple, but it's certainly worth a look. |
|
Hints for shop items should be better now. Need to go back over current dev branch to make sure I'm not missing some hint types/changes that may or may not have occurred since when I first made this. |
…pwright into feat/hooks/custom-message
Pepper0ni
left a comment
There was a problem hiding this comment.
Only 1 oversight to patch then I'm fine with this.
This PR is my effort to convert our old Custom Message systems to use the OnTextLoad hook that I backported from 2Ship, and ShipInit to replace our previous methods for displaying Custom Messages. Some articles, colors, and icons got lost in translation that I know of, so it's not 100% done yet. However these are all visual, so playtesters are safe to go ahead and try this build out to see if they can find any bugs like text popping up in the wrong places or hooks not getting registered properly.
Build Artifacts