presets: clear blocks#5098
Conversation
0918c1b to
dc6dcd4
Compare
this avoids needing to list every new cvar in presets.h
dc6dcd4 to
81b92be
Compare
aMannus
left a comment
There was a problem hiding this comment.
Thanks for picking this up! 2 small things, one of which is my own baguette (sowwy)
soh/soh/Enhancements/presets.h
Outdated
| CVAR_SETTING("DpadInText"), | ||
| CVAR_SETTING("OcarinaControl.Dpad"), | ||
| CVAR_SETTING("OcarinaControl.RStick"), |
There was a problem hiding this comment.
We should just get rid of the enhancement and randomizer cvar lists and only clear by blocks. The ones that were in this before shouldn't really have been reset anyway, and if any of these settings becomes a concern for racing down the line, they shouldn't live in settings anyway.
Means you can remove them where Malk placed a comment too.
There was a problem hiding this comment.
Should I also remove from presets things which don't fall into the blocks? ie vanillaPlusPresets sets CVAR_SETTING("DpadInText"), CVAR_SETTING("OcarinaControl.Dpad"), CVAR_SETTING("OcarinaControl.RStick")
Even randomizer, which only cleared randomizer blocks to begin with, touches settings/enhancements. I saw someone complain about not wanting to touch rando presets because of fear of their non-rando settings getting screwed up. But this might also be fine to punt on for now here since there's the follow up of #4851
There was a problem hiding this comment.
Yeah I don't think we should in the future. The problem with randomizer presets was it was also touching enhancements though, not just settings. But maybe it's a good rule to follow from now on. Enhancement presets can only touch stuff inside enhancements (and cheats but that'll move to the enhancement tab in the new menu anyway), randomizer preset can only touch randomizer settings etc.
I do foresee some settings we'd probably want to enable in these presets though, but we can hold a discussion if those need to be moved to enhancements later then.
5cab0f3 to
9b295d3
Compare
this avoids needing to list every new cvar in presets.h
fixes #4906
Build Artifacts