Conversation
| gSaveContext.seqId = (u8)NA_BGM_DISABLED; | ||
| gSaveContext.natureAmbienceId = 0xFF; | ||
| gSaveContext.gameMode = GAMEMODE_TITLE_SCREEN; | ||
| gSaveContext.gameMode = GAMEMODE_FILE_SELECT; |
There was a problem hiding this comment.
This was incorrectly the wrong value, but was masked by a different src change below. This should be GAMEMODE_FILE_SELECT, which normally would be set by ovl_en_mag, but we are skipping the opening sequence so we set it here.
|
|
||
| // Originally this was only set when transitioning from the title screen, but gSkipLogoTitle skips that process so we're ensuring it's set here | ||
| gSaveContext.gameMode = GAMEMODE_FILE_SELECT; |
There was a problem hiding this comment.
This was an old source change added because of the previous skip to file select enhancement. This can be dropped now that we have the improved boot sequence handling (which will guarantee the gamemode is set to GAMEMODE_FILE_SELECT before loading the file select state. (see my previous comment)
| } | ||
|
|
||
| gSaveContext.gameMode = GAMEMODE_FILE_SELECT; | ||
| SET_NEXT_GAMESTATE(gGameState, FileChoose_Init, FileChooseContext); |
There was a problem hiding this comment.
Add missing gameMode set here, and switching to use gGameState
leggettc18
left a comment
There was a problem hiding this comment.
Looks good to me! I'm assuming decomp is using these already and we just hadn't updated until now?
Updates src to use the
GAMEMODEenum.Two spots had an explicit change that I will callout below. Everything else is just magic number -> matching enum value.
Build Artifacts