logic: allow finding big poe in bottle for reward logic#5075
Merged
aMannus merged 2 commits intoHarbourMasters:developfrom Feb 25, 2025
Merged
logic: allow finding big poe in bottle for reward logic#5075aMannus merged 2 commits intoHarbourMasters:developfrom
aMannus merged 2 commits intoHarbourMasters:developfrom
Conversation
Contributor
Author
|
this could easily be generalized to more poes:
|
Archez
reviewed
Feb 16, 2025
| if (BottleRandomizerGetToItemID.contains(randoGet)) { | ||
| itemId = BottleRandomizerGetToItemID[randoGet]; | ||
| } | ||
| if (randoGet == RG_BOTTLE_WITH_BIG_POE && !ctx->GetOption(RSK_BIG_POE_COUNT).Get()) { |
Contributor
There was a problem hiding this comment.
I would prefer an explicit numeral comparison to 1, instead of a converting to boolean.
Contributor
Author
There was a problem hiding this comment.
The comparison would be == 0 or + 1 == 1 since the option's 0 value is 1 big poe
Contributor
Author
There was a problem hiding this comment.
I went ahead & pushed as a separate commit handling multiple big poe bottles, if that's preferable it renders this obsolete
only applies when big poe count is set to 1
594a975 to
bc0dcde
Compare
aMannus
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build Artifacts