Added and implemented TrailType enum#5059
Conversation
briaguya0
left a comment
There was a problem hiding this comment.
my first instinct was to check if decomp docs matched, but trailType is new to soh (added in #1473)
it'd be great to use this PR as an opportunity to document that with comments. just adding // SOH [Enhancements] to the lines where trailType is added to a struct would go a long way
|
@briaguya-ai should I refactor some of the trail code into functions in this PR or should I limit this just to the enum change? There's some unnecessarily repeated code, especially in the switch statement |
i think leaving this PR as just the enum change makes sense. you can branch off this branch and make a new PR for the refactor, and if this doesn't land before that we can just get this change in via that |
This is a revival of an older PR.
This PR resolves issue #1537. I've created an implemented a TrailType enum to reduce magic numbers in the codebase.
Build Artifacts