remove unused VB_SHOULDs#5056
Merged
aMannus merged 6 commits intoHarbourMasters:developfrom Feb 14, 2025
Merged
Conversation
briaguya0
commented
Feb 13, 2025
Comment on lines
-525
to
-531
| // Replace the blue warp transitions with ones that lead back to the chamber of sages | ||
| case VB_BLUE_WARP_APPLY_ENTRANCE_AND_CUTSCENE: { | ||
| DoorWarp1* blueWarp = va_arg(args, DoorWarp1*); | ||
| BossRush_HandleBlueWarp(gPlayState, blueWarp->actor.world.pos.x, blueWarp->actor.world.pos.z); | ||
| *should = false; | ||
| break; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
i couldn't find a GameInteractor_Should that uses this
Contributor
Author
There was a problem hiding this comment.
it was added in #4255, but i could only find one instance of it in there
briaguya0
commented
Feb 13, 2025
| case VB_GIVE_ITEM_STRENGTH_1: | ||
| case VB_GIVE_ITEM_ZELDAS_LETTER: | ||
| case VB_GIVE_ITEM_OCARINA_OF_TIME: | ||
| case VB_GIVE_ITEM_KOKIRI_EMERALD: |
Contributor
Author
There was a problem hiding this comment.
couldn't find a GameInteractor_Should that uses this https://github.com/search?q=repo%3AHarbourMasters%2FShipwright+VB_GIVE_ITEM_KOKIRI_EMERALD&type=code
Contributor
Author
There was a problem hiding this comment.
looks like this was added in 596ea5e but i couldn't find it being used in there either
aMannus
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4997
after going through everything in #4997 i verified the docs had been updated for everything mentioned in that issue.
this PR just removes the leftover unused ones
Build Artifacts