Fix issues leftover from PR #5023#5054
Merged
aMannus merged 1 commit intoHarbourMasters:developfrom Feb 13, 2025
Merged
Conversation
aMannus
approved these changes
Feb 13, 2025
Contributor
aMannus
left a comment
There was a problem hiding this comment.
I wonder if we can break up this giant statement in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some locations that normally didn't end up in the pool ended up in the pool after changes from PR #5023 which caused some problems generating seed with certain combinations of settings. This may not have solved all of them, but I definitely solved the two issues that I know of, which is Adult Trade Shuffle and Fishsanity.
Build Artifacts