Move Broken Giant's Knife fix hook to its own file#5049
Merged
aMannus merged 5 commits intoHarbourMasters:developfrom Feb 28, 2025
Merged
Move Broken Giant's Knife fix hook to its own file#5049aMannus merged 5 commits intoHarbourMasters:developfrom
aMannus merged 5 commits intoHarbourMasters:developfrom
Conversation
aMannus
requested changes
Feb 25, 2025
Contributor
aMannus
left a comment
There was a problem hiding this comment.
Looks good, 2 small comments
aMannus
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lemme tell ya, I'm so compelled to define a
COND_ITEM_RECEIVEmacro that registers a hook conditioned only on the ID of the received item, but I've seen so many hooks that require more data fromGetItemEntry, it's not worth it.Build Artifacts