Use VB hook to fix Deku Nut upgrade bug#5047
Conversation
There was a problem hiding this comment.
Ok sorry for the split reviews 😅 just noticed two more things, one commented below, and the other is the following:
When not in a rando save while skip misc interations is on, we bypass the flow for mask judging which means your VB_DEKU_SCRUBS_REACT_TO_MASK_OF_TRUTH wont be triggered and therefore the "fix" wont take effect (unsetting the flag)
To counteract that, we can "cheat" by placing a GameInteractor_Should(VB_DEKU_SCRUBS_REACT_TO_MASK_OF_TRUTH, true) before the flag set in timesave_hook_handlers.cpp:EnDntDemo_JudgeSkipToReward
I was thinking another alternative would be to change this from a VB hook to an ActorInit hook. But that would leave the edge case of the option being turned on while Link is already in the Forest Stage. Am I wrong on that? Do ActorInit hooks get called immediately upon registration if the corresponding actor is present? |
Yea using |
Alternative to #4777. Changes the retroactive flag fix from a wasteful frame update hook to a lazy VB hook.
I'd like some feedback on whether there's a difference between this and #4777 in terms of how they affect rando. Just in case, I've kept the
IS_RANDOpart of the hook.Build Artifacts