Remove POLY_KAL and restore POLY_OPA for kaleido#5041
Merged
aMannus merged 1 commit intoHarbourMasters:developfrom Feb 12, 2025
Merged
Remove POLY_KAL and restore POLY_OPA for kaleido#5041aMannus merged 1 commit intoHarbourMasters:developfrom
aMannus merged 1 commit intoHarbourMasters:developfrom
Conversation
Archez
commented
Feb 11, 2025
Comment on lines
-195
to
-198
| // #region SOH [General] | ||
| // Upstream TODO: Document reasoning for these only existing in SoH | ||
| #define POLY_KAL_DISP __gfxCtx->polyKal.p | ||
| // #endregion |
Contributor
Author
There was a problem hiding this comment.
Very happy to be able to finally get rid of all the added buffers from launch 🎉
Contributor
|
Still need to review the actual code, but from a brief playtest on linux so far it all works fantastically. Even the custom Kaleido menu I added. I figured if anything would have an issue it'd be that but it seems to behave exactly as before. |
leggettc18
approved these changes
Feb 12, 2025
aMannus
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POLY_KALwas a custom buffer we originally added on the launch of the port to handle rendering kaleido and the game world at the same time, such that kaleido was over the game world (OPA & XLU) but under the OVERLAY.Now that the game world is no longer rendered and a framebuffer capture is used for kaleido, we can finally revert kaleido back to using
POLY_OPAlike the original source code and remove all port additions around polyKal.The changes largely consist of renames from
POLY_KAL_DISP->POLY_OPA_DISPand then removing any specific graphics setup code around polyKal.Build Artifacts