ShipInit and move ValueViewer rendering out of src#5039
Merged
aMannus merged 1 commit intoHarbourMasters:developfrom Feb 12, 2025
Merged
ShipInit and move ValueViewer rendering out of src#5039aMannus merged 1 commit intoHarbourMasters:developfrom
aMannus merged 1 commit intoHarbourMasters:developfrom
Conversation
| COND_HOOK(OnGameFrameUpdate, CVAR_VALUE, []() { ValueViewer_SetupDraw(); }); | ||
| } | ||
|
|
||
| RegisterShipInitFunc initFunc(RegisterValueViewerHooks, { CVAR_NAME }); |
Contributor
There was a problem hiding this comment.
Is this safe to do this outside of the draw loop?
Contributor
Author
There was a problem hiding this comment.
Its not outside the draw loop, OnGameFrameUpdate is executed before drawing is finished.
Which is essentially equivalent to where the value viewer draw was added before (from the code diff), so in terms of the Gfx buffer it is setup nearly identically (+/- an extra pair of OPEN/CLOSE_DISPS).
Contributor
There was a problem hiding this comment.
perfect, appreciate the thoroughness
leggettc18
approved these changes
Feb 12, 2025
aMannus
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses ShipInit to register and move the ValueViewer rendering to the game state update hook (which places the value viewer draw at the end of the display buffers).
Also cleaned up some left over references for the collision viewer draw method.
Build Artifacts