Restore pause link drawing behavior to use the work buffer#5038
Merged
aMannus merged 1 commit intoHarbourMasters:developfrom Feb 11, 2025
Merged
Restore pause link drawing behavior to use the work buffer#5038aMannus merged 1 commit intoHarbourMasters:developfrom
aMannus merged 1 commit intoHarbourMasters:developfrom
Conversation
Contributor
|
There's a weird interaction that you can trigger, at least on Linux, need to test if it happens on other platforms and/or base develop. Basically, if you have the window small enough that the Enhancements->Graphics menu overlaps the bottom edge of the window, toggle Animated Pause Menu Link, and then hit F1, the graphics go into a weird glitchy state where it constantly alternates between a corrupted frame and the normal one. Will see if I can replicate this on any other platforms in a couple hours. EDIT: Already confirmed this isn't a new issue with this build. Will give an approval review here and post a separate issue with a video. |
leggettc18
approved these changes
Feb 11, 2025
aMannus
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores some of the pause link draw code back to decomp src, where it creates two DLs (for OPA and XLU draws of Link) and then executes those as part of the work buffer which is the very first draw calls (work -> opa -> xlu -> overlay)
This is preemptive work to get us to rip out the custom added
polyKalbuffer which is no longer needed with the newer frame buffer handling for kaleido's background.There was some extra hacks to force the triforce draw (which uses XLU internally) that made a temp and overwrote XLU to be the end of OPA. This is no longer necessary with these changes and can be simplified.
Here is how it looks in the Gfx Debugger, where OPA DL and XLU DL are the set-aside allocated buffers for the Link draws.
Build Artifacts