fix dark link not getting hit when stunned#5028
Merged
Archez merged 1 commit intoHarbourMasters:developfrom Feb 9, 2025
Merged
fix dark link not getting hit when stunned#5028Archez merged 1 commit intoHarbourMasters:developfrom
Archez merged 1 commit intoHarbourMasters:developfrom
Conversation
in HarbourMasters#3280 both `0x00400000` and `0x04000000` were replaced with `PLAYER_STATE1_SHIELDING`. `0x00400000` is `PLAYER_STATE1_SHIELDING`, but `0x04000000` is `PLAYER_STATE1_DAMAGED` this fixes the spots in `z_en_torch2` where we had `PLAYER_STATE1_SHIELDING` where it should have been `PLAYER_STATE1_DAMAGED`
inspectredc
approved these changes
Feb 9, 2025
Member
inspectredc
left a comment
There was a problem hiding this comment.
Ah I hope this is just isolated to this file, really sorry for the 🥖
Contributor
Author
no worries at all! i approved that PR so it's my 🥖 too i did notice one other spot where the same incorrect replacement happened - that one is a strange one though #5029 |
Archez
approved these changes
Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #3280 both
0x00400000and0x04000000were replaced withPLAYER_STATE1_SHIELDING.0x00400000isPLAYER_STATE1_SHIELDING, but0x04000000isPLAYER_STATE1_DAMAGEDthis fixes the spots in
z_en_torch2where we hadPLAYER_STATE1_SHIELDINGwhere it should have beenPLAYER_STATE1_DAMAGEDBuild Artifacts