Skip to content

Fix save warping in links house with entrance rando#5009

Merged
Malkierian merged 2 commits intoHarbourMasters:developfrom
Archez:fix-er-savewarp-links-house
Feb 6, 2025
Merged

Fix save warping in links house with entrance rando#5009
Malkierian merged 2 commits intoHarbourMasters:developfrom
Archez:fix-er-savewarp-links-house

Conversation

@Archez
Copy link
Contributor

@Archez Archez commented Feb 5, 2025

When save warping in Link's house in Entrance Rando with overworld spawns, Adult Link would be moved to the Child Spawn override.

This changes the save warp behavior to just retain Link in his house regardless of age (following vanilla behavior).

Fixes #4980

Build Artifacts

@leggettc18
Copy link
Contributor

leggettc18 commented Feb 6, 2025

I think there's potential for this to softlock in certain scenarios, unless there's something in entrance rando code that prevents this, even for No Logic. If entrances are decoupled and Link's house exits to a boss that you can't beat and can't go back through the door, saving in either room will cause you to get permanently stuck between those two rooms. And the only real way to avoid this softlock is to save before every entrance because by the time you know you're in this situation it's already too late unless you restart without saving, which could lose lots of progress.

I think the better solution here would be to prevent the vanilla behavior of adult respawning in Link's house if interior entrances are shuffled.

@Archez
Copy link
Contributor Author

Archez commented Feb 6, 2025

Good catch, added a "shuffle interiors all" check to the links house logic, otherwise just falls back to the regular spawn behavior.

@Malkierian Malkierian merged commit eafe7f0 into HarbourMasters:develop Feb 6, 2025
5 checks passed
@Archez Archez deleted the fix-er-savewarp-links-house branch February 7, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Adult can save warp from Link's House to child's spawn

3 participants