shipinit dont show master sword#4989
Merged
aMannus merged 27 commits intoHarbourMasters:developfrom Feb 12, 2025
Merged
Conversation
aMannus
reviewed
Feb 4, 2025
Contributor
aMannus
left a comment
There was a problem hiding this comment.
Small shipinit comment. Also, not entirely sure how we should fix the OnPlayerUpdate problem, maybe run it on a hook when that B button gets updated in the first place?
Comment on lines
+114
to
+115
|
|
||
| static RegisterShipInitFunc initFuncAlways(RegisterNoMasterSword); |
Contributor
There was a problem hiding this comment.
You'll want to change this to static RegisterShipInitFunc initFunc(RegisterNoMasterSword, { "IS_RANDO" });
This way it gets registered and unregistered on save file load, instead of on boot and checkbox toggling. At that point any of the other IS_RANDO checks can also be removed.
briaguya0
commented
Feb 4, 2025
aMannus
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this does:
what this doesn't do
OnPlayerUpdate- it's just doing the same thing as before but using shipinit insteadBuild Artifacts