Defer scene DList resource loading to in-game and support alt pathing#4986
Merged
briaguya0 merged 2 commits intoHarbourMasters:developfrom Feb 4, 2025
Merged
Conversation
briaguya0
approved these changes
Feb 4, 2025
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
i don't have a full understanding of the greater context of where the resource loads end up actually happening with this change, but all of the changes in this PR seem very reasonable.
i left a couple little comments in places where i think we can rip out some unused stuff, but i'm happy with landing this as-is.
Contributor
Author
The resource is loaded later when the string gets passed into our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the scene mesh importer to assign the polygon DList's as resource strings, instead of loading the resource in that moment.
This achieves two main things:
Using resource strings aligns with how we implemented alt-toggling for skeletons.
Build Artifacts