Fix issue with pause buffer input window on save prompt close#4975
Merged
leggettc18 merged 1 commit intoHarbourMasters:developfrom Feb 11, 2025
Merged
Conversation
…osing save prompt state and move code around to be in order of operations
briaguya0
reviewed
Jan 30, 2025
| )) { | ||
| inputBufferTimer = 0; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
might be nice to have a little "where are steps 3 and 4????" comment in here
Contributor
There was a problem hiding this comment.
Why is it numbered the way it is?
Contributor
There was a problem hiding this comment.
steps 3 and 4 happen in the VB_KALEIDO_UNPAUSE_CLOSE handler
i guess one way to make sure everything is in order would be to split this up into 2
COND_HOOK(OnGameStateMainStart methods, call steps 1 and 2 in the first, then have the VB_KALEIDO_UNPAUSE_CLOSE handler right after that, then call step 5 in the second
briaguya0
approved these changes
Feb 4, 2025
leggettc18
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moved code around to be in order of operations
Build Artifacts