Skip to content

NPC souls#4949

Draft
serprex wants to merge 3 commits intoHarbourMasters:developfrom
serprex:npc-souls
Draft

NPC souls#4949
serprex wants to merge 3 commits intoHarbourMasters:developfrom
serprex:npc-souls

Conversation

@serprex
Copy link
Contributor

@serprex serprex commented Jan 24, 2025

@serprex serprex force-pushed the npc-souls branch 4 times, most recently from a686d44 to 9d8bfaf Compare January 26, 2025 18:32
@serprex
Copy link
Contributor Author

serprex commented Jan 26, 2025

Listing things I need to do in PR description, but one point I'm just not sure how to handle are NPC souls which logically block (Talon, King Zora, Mido, other Kokiri guard)

So far I've only implemented Talon, but wondering if they'll require some kind of ghost actor which can only be dispelled once their soul is acquired. But that seems like quite a bit of work, so for first iteration I'd just want using the absence of a soul to be going out of logic. In that iteration Mido's soul wouldn't be implemented (edit: Talon at least can despawn his milk crates at castle to prevent early Zelda)

Another issue is Letter from Zelda / Song from Impa. Right now I'm thinking let those checks be acquired without souls, other option is to require both souls before Zelda's Letter is given

@serprex serprex force-pushed the npc-souls branch 7 times, most recently from bccc7e7 to 8294bc5 Compare January 29, 2025 02:55
@serprex serprex marked this pull request as ready for review January 29, 2025 04:23
@TheLynk
Copy link
Contributor

TheLynk commented Feb 7, 2025

crash randomize seed in last version :
Ship of Harkinian.log
image
image
image
image
image
image
No location excluded and no trick / logic : glitchless

@serprex
Copy link
Contributor Author

serprex commented Feb 10, 2025

Disable ice traps. I need to fill in some more item text for that to function

@serprex serprex marked this pull request as draft April 3, 2025 23:18
@Blazingflare
Copy link

Listing things I need to do in PR description, but one point I'm just not sure how to handle are NPC souls which logically block (Talon, King Zora, Mido, other Kokiri guard)

So far I've only implemented Talon, but wondering if they'll require some kind of ghost actor which can only be dispelled once their soul is acquired. But that seems like quite a bit of work, so for first iteration I'd just want using the absence of a soul to be going out of logic. In that iteration Mido's soul wouldn't be implemented (edit: Talon at least can despawn his milk crates at castle to prevent early Zelda)

Another issue is Letter from Zelda / Song from Impa. Right now I'm thinking let those checks be acquired without souls, other option is to require both souls before Zelda's Letter is given

I have a suggestion for how to work around this.
You could have those specific blocking NPCs (or potentially even all NPCs) altered so that their colors are dull and grayscale (similar to the unused dull state for the spiritual stones) and have their animation speed set to basically zero so they visually don't animate. And if it's not possible to prevent interacting with them entirely until you have their soul, they could be set to use Navi's dialog for the dead castle town gaurd "They aren't moving anymore..."
It would leave them looking like soulless statues while still letting them perform their logical purpose, and prevent the need to make a custom actor or similar to take their place.

@serprex serprex mentioned this pull request Apr 4, 2025
@serprex serprex force-pushed the npc-souls branch 2 times, most recently from e278582 to b93e680 Compare May 11, 2025 23:25
@serprex serprex mentioned this pull request May 26, 2025
@serprex serprex force-pushed the npc-souls branch 3 times, most recently from 79aeb1d to 7d83013 Compare June 22, 2025 06:42
@mobby45
Copy link

mobby45 commented Jul 6, 2025

Bug Found on TheLynk#1, It tells me that Rauru is doable while i can't do it even though i have his soul. i think it needs the mastersword to do it

@Xandervile
Copy link

I noticed a logic issue earlier today (idk if it's been fixed yet as my build could be old? idk) - Carpenter souls are not being taken properly into account for Gerudo Fortress rescuing, it COULD be part of your "souls blocking things" thing, but when I had all 4 Carpenters enabled, it assumed I could free them in Sphere 0, which was a problem as one of the Carpenters was locked behind them being freed by being in Haunted Wasteland in logic.

@serprex
Copy link
Contributor Author

serprex commented Jul 6, 2025

Carpenter logic was recently cleaned up, so probably some merge conflict you hit. Will look into next time I rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants