Conversation
ccedfa7 to
b86ff22
Compare
468929e to
5431caf
Compare
aMannus
left a comment
There was a problem hiding this comment.
Want to bring up the naming point, and also tagged all the vanilla code changes. Most of these will likely just become a VB_Should. Might help with the effort to bring them over later, just figured it'd be nice to have an indication of how many there are and a list where we can cross them off as they are changed.
soh/soh/Network/Anchor/Anchor.cpp
Outdated
|
|
||
| #include "Anchor.h" | ||
| #include <nlohmann/json.hpp> |
There was a problem hiding this comment.
I've thrown up this ball on discord recently, but I'd like to put it out there for more public consideration. So far, this has always been called Anchor, which makes sense when you're trying to communicate it being separate from SoH itself. However, now that we're looking to upstream this, I'd personally really like if we rename everything currently called anchor to something more directly descriptive.
For example, my personal recommendation: Online Multiplayer.
I know a lot of people know the name Anchor by now, but I think there's going to be issues with people that download a normal SoH build and seeing "Anchor" in the network tab without having the description from the Anchor PR that people have now. Compare that to them seeing "Online Multiplayer", I don't think I have to explain people are going to understand what that means more quickly.
Just food for thought, I don't think I'll ever be in a position to force a change like this especially with Anchor's history, but I do think this is the right move.
5431caf to
3e15516
Compare
3e15516 to
332d8f4
Compare
332d8f4 to
c65e5c6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
d52690d to
ae9136a
Compare
|
This PR has been updated with various fixes, and all vanilla code touch points have been migrated to hooks. The known remaining issues are listed at the bottom of the PR. |
be95bea to
03fcbeb
Compare
bb8f4d3 to
e75ad66
Compare
Malkierian
left a comment
There was a problem hiding this comment.
Honestly, with the footprint into existing code being so miniscule now, and with the playtesting that has been ongoing for so long, I think this can just be merged. I'll give anyone who disagrees 2 days to voice it.
aa706d4 to
766d5de
Compare
This is far and away the proudest thing I have been apart of in the Zelda community. Thank you to everyone who either directly or indirectly contributed to this effort. If I forgot to co-author you and you were involved, know that I simply forgot but still appreciated your help! Also thank you to the literal tens of thousands of people who have played Anchor, providing feedback and bug reports. Super thrilled to finally have this merged into the main Ship of Harkinian experience. Co-authored-by: mattman107 <65982675+mattman107@users.noreply.github.com> Co-authored-by: David Chavez <david@dcvz.io> Co-authored-by: MelonSpeedruns <melonspeedruns@outlook.com> Co-authored-by: aMannus <mannusmenting@gmail.com> Co-authored-by: Malkierian <malkierian@gmail.com> Co-authored-by: Caladius <Caladius@users.noreply.github.com> Co-authored-by: Patrick12115 <115201185+Patrick12115@users.noreply.github.com> Co-authored-by: PurpleHato <47987542+PurpleHato@users.noreply.github.com> Co-authored-by: balloondude2 <55861555+balloondude2@users.noreply.github.com> Co-authored-by: lilacLunatic <8488221+lilacLunatic@users.noreply.github.com> Co-authored-by: Felix Lee <flee135@users.noreply.github.com> Co-authored-by: Sirius902 <10891979+Sirius902@users.noreply.github.com>
766d5de to
bfa3813
Compare
Please read the known issues & TODO lists below before reporting any bugs or requesting any features.
This is a beta version, be prepared to encounter issues. The stable version can be found here. I am pushing this up now to encourage people to move off of the holiday build, as well as get some broader playtesting on the nightlies in preparation for the 9.0.0 release.
What is this?
Anchor is a co-op mode for Ship of Harkinian. It allows multiple people to play the game together, vanilla or randomizer, sharing inventory items and world flags.
Downloads
Build Artifacts
How To
TODO/Known Issues
Issues saving/loading presets with the network blockUpstream issue, will fix later