Skip to content

Remove excess magic from the MQ GTG pots#4710

Merged
Archez merged 3 commits intoHarbourMasters:developfrom
Pepper0ni:FixMagic
Dec 20, 2024
Merged

Remove excess magic from the MQ GTG pots#4710
Archez merged 3 commits intoHarbourMasters:developfrom
Pepper0ni:FixMagic

Conversation

@Pepper0ni
Copy link
Contributor

@Pepper0ni Pepper0ni commented Dec 17, 2024

This was causing additional, non-progressive magics to be added to the item pool. fixes #4669

Build Artifacts

@Archez
Copy link
Contributor

Archez commented Dec 18, 2024

These were most likely meant to be entered as magic jar items. I'm surprised we don't already have RG_ entries for RG_MAGIC_JAR_SMALL and RG_MAGIC_JAR_LARGE, but we probably should add those, make item table entries, and place them into these pots so that jars are added to the pool properly.

@Pepper0ni
Copy link
Contributor Author

I imagine this is because there are no chest or freestanding magic jars in the game, all sources of magic are temporary drops from pots, grass or enemies. They would likely need a custom item implemented for them, which exposes the issue of a graphic, as the 3D drops setting currently uses the magic meter graphics for the magic jars...

@Archez
Copy link
Contributor

Archez commented Dec 18, 2024

There is vanilla items for magic jar refills, and the progressive magic items display particles with them, much like the progressive nuts/sticks vs nut/stick refills.

@Archez
Copy link
Contributor

Archez commented Dec 18, 2024

To clarify, we don't have to do this in this PR. I was more-so proposing a suggestion to try and maintain the vanilla item pool (we can track that as an issue and decide/resolve later).

@Archez Archez merged commit 35e0a7c into HarbourMasters:develop Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-progressive magic being shuffled when MQ dungeon potsanity is on

3 participants