OTRGlobals cleanup#4251
Merged
Malkierian merged 24 commits intoHarbourMasters:developfrom Nov 19, 2024
Merged
Conversation
Archez
reviewed
Jul 21, 2024
Malkierian
approved these changes
Nov 11, 2024
Contributor
Malkierian
left a comment
There was a problem hiding this comment.
If I'm reading right with the code review that this is just moving a bunch of things, including new headers where needed, and a small bit of formatting changes, I think this is good to go, and long overdue.
Archez
reviewed
Nov 13, 2024
Contributor
There was a problem hiding this comment.
Couple suggestions from me. I'll probably open a PR up into your fork with the changes since I can test on a mac locally to get better visibility of any issues.
Edit: Here is the PR Pepe20129#7
Archez
approved these changes
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully lessen the "I made a change that affects
OTRGlobals, now everything has to recompile" issue.Also, in the past ran into weird issues with adding stuff to
OTRGlobalswhich should be improved by this PR.Build Artifacts