Created and implemented TrailType enum#3973
Created and implemented TrailType enum#3973link5669 wants to merge 16 commits intoHarbourMasters:developfrom
Conversation
inspectredc
left a comment
There was a problem hiding this comment.
Looks good! Nice to have these magic numbers going away :D
Just left a few thoughts I had when going over this
soh/src/code/z_eff_blure.c
Outdated
| void EffectBlure_Destroy(void* thisx) { | ||
| } | ||
|
|
||
| void updateTrailColor(const char* trailName, Color_RGBA8* color, int* changed, int* reset) { |
There was a problem hiding this comment.
I'm thinking these functions might be better moved to a c++ file. They're pretty nice to have and dont need to be specific to trails (I seem to recall seeing these patterns in other sections of the code). Small nitpick for this too would be the general naming format for functions in the codebase is generally pascal case, sometimes with an underscore as a separator for the object like family name and function purpose
There was a problem hiding this comment.
I looked for these patterns in the rest of the code and saw things like this:
Color_RGB8 cButtonsColor = {255, 160, 0};
if (CVarGetInteger("gCosmetics.Hud_CButtons.Changed", 0)) {
cButtonsColor = CVarGetColor24("gCosmetics.Hud_CButtons.Value", cButtonsColor);
}
Is it worth supporting RGBA and RGB in one function?
|
Are you still interested in getting this ready to merge or should this PR and #3971 be open for replacement by a different user? |
|
Going to close this for now. If the creator (or anyone else) feels like picking this up again, feel free to open another PR. |
This PR is in response to issue #1537. I've added and implemented a TrailType enum for weapon trails.
Build Artifacts