Clean up TextIDs and use enums where possible.#3499
Merged
leggettc18 merged 1 commit intoHarbourMasters:develop-randofrom Dec 10, 2023
Merged
Clean up TextIDs and use enums where possible.#3499leggettc18 merged 1 commit intoHarbourMasters:develop-randofrom
leggettc18 merged 1 commit intoHarbourMasters:develop-randofrom
Conversation
leggettc18
approved these changes
Dec 8, 2023
Contributor
leggettc18
left a comment
There was a problem hiding this comment.
Some of this might get overwritten by a larger textID documentation PR that's still in-progress, but for now this is fine if it helps with more rando stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small update as I'm about to add a bunch to this list to make new special hints. This both names every textID in use and uses an enum instead of a raw number where appropriate. It also sorts the enum into numerical order for easier addition.
Build Artifacts