Fix a seed gen bug surrounding new area enum#3497
Merged
leggettc18 merged 2 commits intoHarbourMasters:develop-randofrom Dec 8, 2023
Merged
Fix a seed gen bug surrounding new area enum#3497leggettc18 merged 2 commits intoHarbourMasters:develop-randofrom
leggettc18 merged 2 commits intoHarbourMasters:develop-randofrom
Conversation
Contributor
Author
|
I also included a fix for the settings string that gets set as part of the final seed normally, it was always being set to nothing. This didn't cause any problems because we weren't actually using it anywhere but it's now at least "correct". |
garrettjoecox
approved these changes
Dec 8, 2023
Archez
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new RandomizerArea enum is used to filter dungeonLocations out of allLocations during item placement, but the itemLocations weren't getting a RandomizerArea set until after the playthrough was already confirmed to be beatable, thus we would get a placement error because we wouldn't be able to pull any dungeon locations and never actually set the RandomizerArea. This calls
SetAreaearlier.Build Artifacts