Fix: Jabu MQ minimap mark points#3494
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom Dec 17, 2023
Merged
Fix: Jabu MQ minimap mark points#3494briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
Conversation
Closed
briaguya0
approved these changes
Dec 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Jabu Jabu MQ, when entering the Big Octorok's room, the minimap would randomly display chest icons even though that room has no chests. This behavior was due to a authentically missing minimap mark entry for this room in MQ (the last room in the dungeon) from decomp. Because of the missing entry, N64 hardware would OOB read the next map mark data which just happens to be Forest Temple MQ room 0 (which has no chests). In SoH, however, the OOB read would behave differently, leading to garbage data being read.
This PR adds the 17th entry for Jabu MQ's minimap, matching Jabu Vanilla's minimap entries, indicating there are no chests for this room.
Fixes #1882
Build Artifacts