Stop hardcoding skeleton type to flex#3397
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom Nov 14, 2023
Merged
Stop hardcoding skeleton type to flex#3397briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
Conversation
garrettjoecox
commented
Nov 14, 2023
| } | ||
| } | ||
|
|
||
| skel->type = SkeletonType::Flex; |
Contributor
Author
There was a problem hiding this comment.
The diff might make it hard to see, but this was the issue, we were parsing the SkeletonType, then just re-setting it afterwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an unknown reason, since the introduction of custom models we had hardcoded their skeleton type to
SkeletonType::Flex.This seemingly did not cause any issues, because regardless of skeleton type the actor files had inline draw calls that determined how the skeleton should be drawn.
This was changed in 8.0.0 #2979 in which all actors now ensure to check the skeleton type before attempting to draw. This change now meant that all custom models were now rendered as
SkeletonType::Flex, whether their exported type was flex or not, leading to unknown behavior and/or crashes with all models that aren't specifically meant to be usingSkeletonType::Flex.This PR also removes the hardcoding of LimbType, it doesn't seem like fast64 exports this for now, but if/when we want it to this should account for it.
Build Artifacts