[OTRExporter] Use substr method to determine file extension#3390
Merged
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom Nov 14, 2023
Merged
[OTRExporter] Use substr method to determine file extension#3390briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
briaguya0 merged 1 commit intoHarbourMasters:develop-macreadyfrom
Conversation
Contributor
|
otrexporter pr merged |
Contributor
|
With the other PR merged, you will need to update this to target the commit from upstream |
9ad5ab9 to
9142c38
Compare
Contributor
|
I think you should use the filesystem api to determine the extension instead of an split |
briaguya0
approved these changes
Nov 14, 2023
Contributor
briaguya0
left a comment
There was a problem hiding this comment.
i figure we should get this in, then if you want to move to using std::filesystem for the OTRExporter stuff we can do a bigger PR cleaning up any manual splits everywhere over there
Archez
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See HarbourMasters/OTRExporter#12
Will update this once the PR linked above is accepted and merged...Done!Build Artifacts