[Feature] Remove performDelayedSave functionality from Autosave#3387
Merged
briaguya0 merged 4 commits intoHarbourMasters:develop-macreadyfrom Nov 14, 2023
Merged
Conversation
…xcept Ganon and Chamber of Sages scenes.
Contributor
|
Note: this removal of the delay also removes the logic of preventing a save in fishing pond/bombchu bowling from saving the temp B (which causes sticks on B after a reload from that save or the minigame item to persist) I intend on implementing a much better solution for temp B saving since there are still some ways for that to happen and I think it's the main cause of the "sticks on B" cases we've been seeing. |
Contributor
|
good catch @Archez, guess the MacReady fix will need to be the "just make sure to set |
jbodner09
suggested changes
Nov 12, 2023
17a7f33 to
9b4da0e
Compare
handle temp B on saving outside of kaleido
Contributor
Author
|
Archez's Temp B fix has now been merged to this PR's branch, so this has everything again and should be good for final scrutiny. |
Archez
approved these changes
Nov 14, 2023
briaguya0
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, there was a problem with
performDelayedSavestill being true through resets out of grottos, fairy fountains, or Bombchu Bowling. However, with the entrance overriding that happens inSram_OpenSaveto prevent loading into grottos or fairy fountains with the Remember Save Location enhancement, and the fact that you can still manually save in those locations anyway, it really isn't necessary to keep the delayed save functionality anymore. Bombchu Bowling works just fine as a spawn in point. The check for Chamber of Sages was moved to the top of the checks in Autosave alongside the check forsavedSceneNumbeingSCENE_GANON_BOSS, for obvious reasons for both, and grottos and fairy fountains are already handled in file loading.Also moved
performSaveto a local variable withinAutoSave(), as it is not referenced anywhere else in code.Includes Archez's pending Temp B fix to prevent autosave from saving swapped B items.
Build Artifacts